Skip to content

[mypy] Add/fix type annotations for backtracking algorithms #4055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 24, 2020
Merged

[mypy] Add/fix type annotations for backtracking algorithms #4055

merged 2 commits into from
Dec 24, 2020

Conversation

dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Dec 24, 2020 •
edited
Loading 

$ mypy --strict backtracking/
Success: no issues found in 13 source files

Related Issue: #4052

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Dec 24, 2020
@dhruvmanila dhruvmanila requested a review from cclauss December 24, 2020 10:36
@ghost ghost added the tests are failing Do not merge until tests pass label Dec 24, 2020
@ghost ghost removed the tests are failing Do not merge until tests pass label Dec 24, 2020
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Dec 24, 2020
@dhruvmanila dhruvmanila merged commit f3ba9b6 into TheAlgorithms:master Dec 24, 2020
@dhruvmanila dhruvmanila deleted the fix-mypy-backtracking branch December 25, 2020 08:03
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@dhruvmanila @stokhos
[mypy] Add/fix type annotations for backtracking algorithms (TheAlgor…
b21d9e1 
…ithms#4055)

* Fix mypy errors for backtracking algorithms

* Fix CI failure
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@dhruvmanila @peRFectBeliever
[mypy] Add/fix type annotations for backtracking algorithms (TheAlgor…
6e772e4 
…ithms#4055)

* Fix mypy errors for backtracking algorithms

* Fix CI failure
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@dhruvmanila
[mypy] Add/fix type annotations for backtracking algorithms (TheAlgor…
8f054cc 
…ithms#4055)

* Fix mypy errors for backtracking algorithms

* Fix CI failure
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@dhruvmanila @shermanhui
[mypy] Add/fix type annotations for backtracking algorithms (TheAlgor…
0f2c138 
…ithms#4055)

* Fix mypy errors for backtracking algorithms

* Fix CI failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhruvmanila @cclauss